refactor(dap): split dap and dap_ui integrations #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Pull Request makes 3 changes to the nvim-dap integration: 1. Splits the dap and dap_ui integrations. Rationale: there's no need for both plugins to share a integration. In fact, that's the only integration that contains multiple plugins. 2. Adds a missing highlight group to the nvim-dap integration 3. Removes a misguided comment about enabling the nvim-dap integration
igorlfs
changed the title
|
Hey, thanks for your pull request. There are some things you forgot, you should:
I'm busy right now, will take a look a bit later. |
dap = { enabled = true, dap_ui = true }should be auto converted to dap = true, dap_ui = trueSomething like this would work (Please verify very carefully): if O.integrations.dap.enabled and O.integrations.dap.dap_ui ~= nil then
O.integrations.dap_ui = O.integrations.dap.dap_ui
end
|
|
Failed on Failed to run `config` for catppuccin
...chilly/code/git/catppuccin/lua/catppuccin/lib/mapper.lua:30: attempt to index field
'dap' (a boolean value) |
nullchilly
changed the title
|
Hey! Thanks for merging! I've been kinda busy lately, so I couldn't catch up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request makes 3 changes to the nvim-dap integration:
I'm not sure why, but the integrations are not enabled by default. Did I forget something?